Skip to content

Chain agnostic dolos core#963

Draft
nicolasLuduena wants to merge 87 commits intomainfrom
refactor/agnostic-core
Draft

Chain agnostic dolos core#963
nicolasLuduena wants to merge 87 commits intomainfrom
refactor/agnostic-core

Conversation

@nicolasLuduena
Copy link
Copy Markdown
Member

This pull request refactors error handling and type constraints throughout the Cardano-related modules to use more specific error types (ChainError<crate::CardanoError>) and domain traits (CardanoDomain). It also updates the genesis type to CardanoGenesis and improves type safety and clarity in various function signatures and trait bounds. These changes lay the groundwork for better error reporting, more precise typing, and easier future maintenance.

Error Handling and Type Improvements

  • Changed many function signatures and trait bounds to return ChainError<crate::CardanoError> instead of a generic ChainError, enabling more precise error handling across the Cardano codebase. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13] [14] [15] [16] [17] [18]
  • Updated trait bounds and function generics to require CardanoDomain instead of the generic Domain, enforcing Cardano-specific constraints at compile time. [1] [2] [3] [4] [5] [6]

Genesis Type Consistency

  • Replaced usage of the generic Genesis type with CardanoGenesis throughout the code, including in struct fields, function parameters, and trait implementations, to ensure type consistency and clarity. [1] [2] [3] [4] [5]

Functionality and Logic Adjustments

  • Improved AVVM reclamation logic to use a Cardano-specific hash conversion and error handling, and updated the method for computing remaining AVVM UTxOs.
  • Updated the nonce stability window calculation to propagate chain-specific errors and improved error handling in related functions. [1] [2]

General Codebase Cleanup

  • Removed unused imports and updated import statements to reflect the new types and traits being used. [1] [2] [3] [4] [5] [6]

These changes collectively improve the maintainability, type safety, and error reporting capabilities of the Cardano modules.

@nicolasLuduena nicolasLuduena marked this pull request as draft April 9, 2026 18:44
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 9, 2026

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 3025b7ed-f05d-4260-91f8-7e013be7fc8b

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch refactor/agnostic-core

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@nicolasLuduena nicolasLuduena changed the title Refactor/agnostic core Chain agnostic dolos core Apr 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant